This is the mail archive of the cygwin-apps mailing list for the Cygwin project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH cygport 2/3] Don't allow SRC_URI or PATCH_URI to depend on ARCH

From: Jon Turney <jon dot turney at dronecode dot org dot uk>
To: cygwin-apps at cygwin dot com
Date: Tue, 2 May 2017 14:39:03 +0100
Subject: Re: [PATCH cygport 2/3] Don't allow SRC_URI or PATCH_URI to depend on ARCH
Authentication-results: sourceware.org; auth=none
References: <20170502131345.158584-1-jon.turney@dronecode.org.uk> <20170502131345.158584-1-jon.turney-GrJqePx9RPPAJUdA+FbntA@public.gmane.org> <20170502131345.158584-3-jon.turney@dronecode.org.uk> <c92hgc552rfd3h6jb3g6bn4g2vi6hsba4d@4ax.com>

On 02/05/2017 14:31, Andrew Schulman wrote:

The values which SRC_URI and PATCH_URI evaluate to should not change
depending on ARCH, as this will make the source package arch-dependent


In that case what's the right thing to do when we have arch-specific
patches? For example screen has one, for x86_64 only.


You could wrap C code in the patch in #ifdef __x86_64__ / #endif

However, looking at screen-terminfo-autoconf.patch, it would seem to beentirely benign to use that on x86.

I don't quite understand how screen reliably builds on any x86_64platform without that patch...

Follow-Ups:
- Re: [PATCH cygport 2/3] Don't allow SRC_URI or PATCH_URI to depend on ARCH
  - From: Andrew Schulman

References:
- [PATCH cygport 0/3] cygport patches
  - From: Jon Turney
- [PATCH cygport 2/3] Don't allow SRC_URI or PATCH_URI to depend on ARCH
  - From: Jon Turney
- Re: [PATCH cygport 2/3] Don't allow SRC_URI or PATCH_URI to depend on ARCH
  - From: Andrew Schulman

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]