This is the mail archive of the
mailing list for the Cygwin project.
Re: [ANNOUNCEMENT] TEST RELEASE: Cygwin 2.5.0-0.8
- From: Ken Brown <kbrown at cornell dot edu>
- To: cygwin-apps at cygwin dot com
- Date: Sun, 20 Mar 2016 13:29:16 -0400
- Subject: Re: [ANNOUNCEMENT] TEST RELEASE: Cygwin 2.5.0-0.8
- Authentication-results: sourceware.org; auth=none
- References: <announce dot 20160318203409 dot GA11113 at calimero dot vinschen dot de> <56EC6BDA dot 7050505 at cornell dot edu> <20160318214509 dot GD11113 at calimero dot vinschen dot de> <56EC8053 dot 40604 at cornell dot edu> <56EC89C2 dot 9010105 at cygwin dot com> <56EC8F50 dot 9020905 at cygwin dot com> <56ECB842 dot 7090807 at cornell dot edu> <20160319103209 dot GE11113 at calimero dot vinschen dot de> <56ED4764 dot 4090007 at cornell dot edu> <56ED9459 dot 8030101 at cornell dot edu> <20160320152625 dot GH11113 at calimero dot vinschen dot de>
On 3/20/2016 11:26 AM, Corinna Vinschen wrote:
On Mar 19 14:03, Ken Brown wrote:
On 3/19/2016 8:34 AM, Ken Brown wrote:
On 3/19/2016 6:32 AM, Corinna Vinschen wrote:
On Mar 18 22:24, Ken Brown wrote:
On 3/18/2016 7:29 PM, Yaakov Selkowitz wrote:
On 2016-03-18 18:05, Yaakov Selkowitz wrote:
On 2016-03-18 17:25, Ken Brown wrote:
The problem I reported in
It looks like your fix
The commit message for removing the include did not indicate what
prompted it. However, the include is necessary for BSD compatibility,
and other software fails to build without it.
I would look into emacs and see what feature test macro(s) they enable
on *Linux*, and use the same for Cygwin.
Might this be it?
This file is part of the Gnulib module that I mentioned in the thread I
There's some seriously hackish things going on in that file, some of
them Cygwin specific.
I think such things are often necessary in Gnulib, but I'll leave it
to comment further. In any case, Eric said in our original
there might be a Gnulib fix for this problem, but then he and Corinna
up deciding it was better to remove the include.
Glibc uses __USE_MISC to guard the inclusion of sys/select.h, newlib's
header uses __BSD_VISIBLE which is almost the same. But we have the
equivalent __MISC_VISIBLE as well. Do you want to change that, Yaakov?
The discussion with Eric was about the POSIX-ness and at the time it
seemed like the simplest solution to remove the include. But Yaakov
is right. If it's the right thing to do for Glibc to include it
with careful guarding, it should be the right thing for us as well.
So I think that means we're back to looking for a Gnulib solution. Eric,
can you follow up on that?
Never mind. I just sent a report to bug-gnulib, so you can follow up there.
Please check what I wrote in response to Paul and correct any mistakes I
might have made.