This is the mail archive of the cygwin-apps mailing list for the Cygwin project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH setup 0/3] Setup replacement for incver_ifdep

From: Jon Turney <jon dot turney at dronecode dot org dot uk>
To: cygwin-apps at cygwin dot com, Ken Brown <kbrown at cornell dot edu>
Date: Sat, 6 Feb 2016 15:30:54 +0000
Subject: Re: [PATCH setup 0/3] Setup replacement for incver_ifdep
Authentication-results: sourceware.org; auth=none
References: <87lhb8htrh dot fsf at Rainer dot invalid> <561FA783 dot 900 at dronecode dot org dot uk> <87oag0qad3 dot fsf at Rainer dot invalid> <20151019154100 dot GB18989 at calimero dot vinschen dot de> <87io62hiz6 dot fsf at Rainer dot invalid> <20151020102150 dot GF5319 at calimero dot vinschen dot de> <56532D34 dot 4090102 at dronecode dot org dot uk> <87bnakmtqc dot fsf at Rainer dot invalid> <56549774 dot 2090008 at dronecode dot org dot uk> <87ziy3utip dot fsf at Rainer dot invalid> <20151126101120 dot GA6674 at calimero dot vinschen dot de> <56AA50E4 dot 2040105 at dronecode dot org dot uk> <56AA6128 dot 8030700 at cornell dot edu> <56AA74BE dot 4010208 at redhat dot com> <56AA7755 dot 8060801 at cornell dot edu> <56AA787A dot 9080503 at redhat dot com> <56AB75A4 dot 6060101 at dronecode dot org dot uk> <56AB7CD7 dot 5000101 at cornell dot edu> <56B6033C dot 3050407 at cornell dot edu>

On 06/02/2016 14:29, Ken Brown wrote:

On 1/29/2016 9:53 AM, Ken Brown wrote:

On 1/29/2016 9:22 AM, Jon Turney wrote:

On 28/01/2016 20:22, Eric Blake wrote:

On 01/28/2016 01:17 PM, Ken Brown wrote:

Second, why is the second line needed, i.e., under what circumstances
would it be expected to succeed after the first install-info command
failed?


Sadly, I don't know install-info enough to answer that one.


I think the first install-info command would fail if the .info file is
missing a START-INFO-DIR-ENTRY/END-INFO-DIR-ENTRY block, in which case
install-info should fail with a 'install-info: warning: no info dir
entry in `xxx.info''

Since such a .info file is apparently valid (although I don't think we
have any instances of such), I guess the nonsense after the || should be
fixed to use '$f' correctly.


I have a few instances of those files on my system:

install-info: warning: no info dir entry in
`/usr/share/info/automake-history.info.gz'
install-info: warning: no info dir entry in
`/usr/share/info/automake-history1.12.info.gz'
install-info: warning: no info dir entry in
`/usr/share/info/automake-history1.13.info.gz'
install-info: warning: no info dir entry in
`/usr/share/info/texdraw.info.gz'

But I'm not convinced that we need to worry about them.  It could be
that they're intended to be cited from other info files but not to be
listed in the top level directory.  I would say that if an info file
lacks a START-INFO-DIR-ENTRY/END-INFO-DIR-ENTRY block, we should assume
that its author didn't want it listed in the directory.


Jon, any further thoughts about this?  texinfo-6.1 has just been
released, so I can go ahead with adding the postinstall script as soon
as we decide what it should do in the case of a missing
START-INFO-DIR-ENTRY/END-INFO-DIR-ENTRY block.

I think you are right, so just drop the || and everything after it.

(As an aside, I don't think it's necessarily correct that those nodesyou list are orphaned, e.g. automake-history1.12.info should be referredto in automake1.12.info, but in fact that has references toautomake-history.info)

Follow-Ups:
- Re: [PATCH setup 0/3] Setup replacement for incver_ifdep
  - From: Jon Turney

References:
- Re: [PATCH setup 0/3] Setup replacement for incver_ifdep
  - From: Ken Brown

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]