This is the mail archive of the cygwin-apps mailing list for the Cygwin project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [ITP] rpcbind 0.2.1

On 2014-08-20 13:22, Pavel Fedin wrote:
  I  have  completed rpcbind package and would like to offer it for the
  The same as onc-rpc-devel, this is x86-64-only for now.

Comments follow.


I'm wondering if onc-rpc-devel (which I'm starting to think should just be called rpcgen) shouldn't obsolete sunrpc too instead of this. It's a bit of a tough call because there is some overlap here.


This should be:


src_install () {
	cd ${B}

These are in /usr/sbin on Fedora, so in this particular case:

cyginstall bindir=/usr/sbin

+#ifndef __CYGWIN__
 	if (geteuid()) { /* This command allowed only to root */

Perhaps this is a candidate for using Daniel Boland's code?

-			syslog(LOG_ERR, "cannot get uid of '%s': %m", id);
+  			syslog(LOG_ERR, "cannot get uid of '%s': %m", id);

This is just a whitespace difference, I suggest you leave it out of your patch to ease future porting.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]