Re: [PATCH 1/4] Add the last element of URL path to site chooser, if interesting.

[Corinna Vinschen <corinna-cygwin at cygwin dot com>]

On Mar  9 12:40, Andy Koppe wrote:
> On 29 November 2010 12:57, Corinna Vinschen wrote:
> > On Nov 26 13:48, Jon TURNEY wrote:
> >> Currently, for example, if I manually add the site http://mirrors.kernel.org/sources.redhat.com/cygwinports/
> >> to setup's mirror list, I get two indistinguishable entries named http://mirrors.kernel.org.
> >>
> >> Furthermore, because the code to ensure the site just added is selected uses the string inside the list control
> >> to locate elements, we end up with a random one of those two indistinguishable entries selected (usually the
> >> previously existing one).
> >>
> >> This problem also prevents the selected sites being correctly saved and restored for the next setup run.
> >>
> >> So, to make the site chooser list entries unique and distinguishable, add the last element of the URL path to
> >> the site chooser, if it exists and isn't 'cygwin' (or some other alternatives used by current mirrors)
> >
> > That sounds a bit problematic. ÂSo two URLs on the same machine might
> > again end up as the same string, undistinguishable, just because they
> > both end in the same directory name? ÂAnd there are (right now) four
> > such directory names, which are treated identically.
> >
> > Don't get me wrong. ÂIt's certainly better than what we have today,
> > and the full URL is almost unreadable. ÂNevertheless, I'd be more happy
> > with a solution which fixes this problem even for such border cases...
> 
> In the apparent absence of further work on this, it would be nice to
> see Jon's patch going in anyway, which most importantly addresses the
> issue for Cygwin Ports mirrors, without making anything worse.

Jon, are you still working on a different version?


Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Project Co-Leader          cygwin AT cygwin DOT com
Red Hat