Re: [ITA] - base-files

[David Sastre <d dot sastre dot medina at gmail dot com>]

On Sun, Mar 06, 2011 at 07:07:18AM +0000, Andy Koppe wrote:
> On 5 March 2011 17:03, Andy Koppe wrote:
> Actually I had already downloaded this anyway. Looks great, only two
> suggestions:
> 
> - Not that it makes a great difference, but I think the interactive
> checks should be done before sourcing /etc/bash.bashrc and ~/.bashrc
> from /etc/profile and ~/.profile, respectively, rather than doing it
> in the rc files. That would save opening the rc files in
> non-interactive login shells and unnecessary checks in interactive
> non-login shells.

That's true, but the check also serves the purpose of avoiding those
files to be sourced in non-interactive sesions, regardless who's
calling.

> - I think the commented-out CVS stuff in /etc/profile would be better
> placed in ~/.bash_profile, to allow non-admin users to uncomment it.
> Or perhaps just delete it altogether; since
> CVSROOT=:pserver:anoncvs@sources.redhat.com:/cvs/src isn't what's
> recommended at http://cygwin.com/cvs.html anymore anyway.

Done. I've dropped it.

> And a question:
> 
> - Can we do away with ~/.bash_profile, and move the commented-out
> PATH, MANPATH, and INFOPATH setting from there into ~/.profile? I see
> the latter sources .bashrc anyway for bash shells, which makes sense.

I'd rather keep .bash_profile around, because it has higher precedence in
case both files exist. Sourcing .bashrc from .profile only exists as a 
fallback mechanism.

In case you are about to upload this, could you please apply this patch 
to your local 4.0-3 copy?
If you think these changes deserve a release bump, I'd roll a 4.0-4
version.

Thanks!

--- a/etc/defaults/etc/profile
+++ b/etc/defaults/etc/profile
@@ -42,12 +42,6 @@ unset TEMP
 read -r PRINTER < '/proc/registry/HKEY_CURRENT_USER/Software/Microsoft/Windows NT/CurrentVersion/Windows/Device'
 PRINTER=${PRINTER%%,*}

-# It is recommended that cvs uses ssh for it's remote shell environment
-# CVS_RSH="/usr/bin/ssh"
-
-# Patches to Cygwin always appreciated ;)
-# CVSROOT=:pserver:anoncvs@sources.redhat.com:/cvs/src
-
 # Default to removing the write permission for group and other
 #  (files normally created with mode 777 become 755; files created with
 #  mode 666 become 644)
@@ -123,7 +117,7 @@ else PS1="$ "
 fi

 export PATH MANPATH INFOPATH USER PRINTER PS1 HOSTNAME
-# export TMP TEMP CVS_RSH CVSROOT
+# export TMP TEMP

 # Check to see if mkpasswd/mkgroup needs to be run try and cut down the emails
 #   about this on the lists!

--- a/usr/share/doc/base-files/ChangeLog
+++ b/usr/share/doc/base-files/ChangeLog
@@ -15,6 +15,7 @@ Change Log
     * Supressed a fork in /etc/profile routine for copying skeletal files and
       added a test to `cd' command - Cyrille Lefevre
     * Removed /bin from path, as it is included via /usr/bin.
+    * Dropped CVS stuff from /etc/profile - Andy Koppe
 4.0-2
     * Never released.
     * A modified version of a case switch to run shell dependent stuff based

-- 
Huella de clave primaria: 0FDA C36F F110 54F4 D42B  D0EB 617D 396C 448B 31EB

Attachment: signature.asc
Description: Digital signature