This is the mail archive of the cygwin-apps mailing list for the Cygwin project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [ITA] - base-files

On 8 December 2010 21:22, David Sastre wrote:
> Hello,
> I have a base-files-4.0-1 package ready to receive testing. You can fetch it
> from this URL:
> md5sums:
> ff8000e0c128c9a7732d17c5eaace129 Âbase-files-4.0-1.tar.bz2
> bcdea646fcf7038f0796c68838759829 Âbase-files-4.0-1.tar.bz2.sig

Thanks for all that work.

I'm afraid there's a syntax error in /etc/profile though:

elif [ ! -O "$HOME" -a "${HOME#/home/}" != "${HOME}" ]

That's missing a "; then".

Also, indentation is rather wonky, due to a mix of tabs and spaces.
You appear to be using a tab size of 2?

> I have decided to pull out of /etc/profile the case switch that tries
> to detect the shell and sets PS1 (and HOSTNAME) accordingly.
> The reason for this change is that all of bash, mksh, zsh and tcsh, provide
> their own files for doing that job. The result is a lighter /etc/profile
> that sets a minimun PS1='$ ' that will be used by posh and dash (the only
> two shells in the repo that lack specific startup files), allowing shells
> that do have that files to alter this setting(s).
> Notice that neither posh nor mksh, despite being ksh derivatives, read
> /etc/ksh.kshrc nor ~/.kshrc.
> (I=interactive,L=login,N=non-interactive,B=bash,M=mksh,Z=zsh,T=tcsh,O=posh,dash,!=not)
> BL=> /etc/profile -> ~/.bash_profile -> ~/.bashrc -> /etc/bash.bashrc

That's not going to work for people whose .bash_profile and .bashrc
don't adhere to that pattern or who don't have those files for
whatever reason, i.e. they'll suddenly get the default "$ " prompt.

> BI!L=> /etc/bash.bashrc -> ~/.bashrc

Doesn't /etc/bash.bashrc end up being sourced twice here, due to
~/.bashrc including it.

I think your startup file list should distinguish between files that
are automatically sourced by the shell and those that are sourced by
other startup files.

Regarding the ChangeLog:

    * New file: skel/.bash_logout: clear the screen after logout.

Why is that necessary? Do other systems do that?


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]