This is the mail archive of the
mailing list for the Cygwin project.
Re: [PATCH] inform user if any postinstall script failed to run
- From: Andy Koppe <andy dot koppe at gmail dot com>
- To: cygwin-apps at cygwin dot com
- Date: Thu, 12 Aug 2010 06:44:49 +0100
- Subject: Re: [PATCH] inform user if any postinstall script failed to run
- References: <4C49D54B.email@example.com>
On 23 July 2010 18:45, Jon TURNEY wrote:
> Here's a small patch for setup.exe which causes setup to indicate if a
> postinstall script didn't run successfully.
> This should help avoid the situation where the postinstall scripts fail to
> run and the user has a broken installation, but they don't notice until they
> try to run something which relies on postinstall scripts, e.g  and I'm
> sure there are other examples.
>  http://cygwin.com/ml/cygwin-xfree/2010-07/msg00084.html
> Â Â Â Â* postinstall.cc : Note if any postinstall script fails and tell
> Â Â Â Âthe user with an error messagebox
> Â Â Â Â* script.cc (run): Don't rename script as .done if it didn't run
> Â Â Â Âsuccessfully
Shall we tone down the error box here a little bit? A postinstall
failure in some obscure package that might only have been installed
due to the user selecting 'All' won't actually impact on the use of
Cygwin. I think the current wording will unnecessarily scare off
unexperienced users who wouldn't know how to correct these failures.
RCS file: /cvs/cygwin-apps/setup/postinstallresults.cc,v
retrieving revision 1.1
diff -u -r1.1 postinstallresults.cc
--- postinstallresults.cc 29 Jul 2010 13:09:04 -0000 1.1
+++ postinstallresults.cc 12 Aug 2010 05:39:21 -0000
@@ -57,10 +57,10 @@
// one or more postinstall scripts failed to run successfully
// installation may be broken
- "You will need to investigate and correct these errors "
- "before your Cygwin installation will function properly.\n"
- "Check setup.log for details.",
- "ERROR - postinstall scripts failed",
+ "The affected packages and those that depend\n"
+ "on them may not function properly.\n"
+ "Check /var/log/setup.log for details.",
+ "ERROR - postinstall script failures",
MB_OK | MB_ICONERROR | MB_SETFOREGROUND | MB_TOPMOST);