Re: genini: message field always emitted

[Christopher Faylor <cgf-use-the-mailinglist-please at cygwin dot com>]

On Fri, Mar 12, 2010 at 09:08:56AM -0500, Charles Wilson wrote:
>Christopher Faylor wrote:
>> On Thu, Mar 11, 2010@09:26:38PM -0500, Charles Wilson wrote:
>>> @@ -87,8 +93,10 @@ sub get {
>>>     my $val = shift;
>>>
>>>     if ($keyhint eq 'message') {
>>> -	my ($kw, $rest) = /^(\S+)\s+(.*)$/;
>>> -	return $kw . ' ' . get($FH, 'ldesc', $rest);
>>> +	if ($val) {
>>> +	    my ($kw, $rest) = $val =~ /^(\S+)\s+(.*)$/;
>>> +	    return $kw . ' ' . get($FH, 'ldesc', $rest);
>>> +	}
>> 
>> This should be checking that $val exists and issuing a syntax error
>> if not.  Otherwise, it looks ok.

Thanks but this seems too complicated for what is required.

I am still email-receive challenged but I checked in a fix which makes
'message' and 'ldesc' optional and issues a parse error when a message
line doesn't look like:

message: foo "bar...

cgf