This is the mail archive of the
mailing list for the Cygwin project.
Re: [PATCH] Two fixes for setup postinstall handling.
On Sun, Aug 10, 2008 at 07:41:03PM +0100, Dave Korn wrote:
>Christopher Faylor wrote on 10 August 2008 16:30:
>> On Sun, Aug 10, 2008 at 02:21:48PM +0100, Dave Korn wrote:
>>> The first hunk finds if bash is in the list of packages that have
>>> scripts to run and swaps it with the first entry if so.
>> If this is necessary, I don't like the idea of special casing bash.
>> Can't we add a keyword to setup.ini so this could be configurable?
>Sure. Or we could make it automagic by looking out for sh.exe when it
>goes by - using the same string we know we're going to be using to
>invoke the scripts later?
My point is that I don't like hardcoding the string "sh.exe" into
>>Sorry but I'm not yet convinced that this is necessary.
>Well, it's still "just plain wrong" to rename a script to ".done" when
>you know for absolute certain that it hasn't been.
No argument there. Maybe that part of the change needs to go in
separately since it sounds like a genuine bug fix.
Btw, I'm happy that you're thinking about this problem. Thank you.