This is the mail archive of the cygwin-apps mailing list for the Cygwin project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Patch for unattended setup (updated)

On Thu, Apr 10, 2008 at 02:31:57PM +0100, Dr. Frank Lee wrote:
>> I will provide an updated patch based on the current CVS with appropriate 
>> GNU coding style and using '-s' for the software package switch.
> I attach an updated patch which I believe conforms to the guidelines.
> Yours,
> Frank
> (Brief summary: exit code 118 -> reboot needed; command line option '-s 
> package1[,package2[,...]]' to install software packages; dialogue boxes 
> with the user are suppressed)

>Common subdirectories: setup-2.590-cvs/.deps and setup-2.590-rfl/.deps
>Common subdirectories: setup-2.590-cvs/.libs and setup-2.590-rfl/.libs
>Common subdirectories: setup-2.590-cvs/CVS and setup-2.590-rfl/CVS
>diff -u setup-2.590-cvs/ChangeLog setup-2.590-rfl/ChangeLog
>--- setup-2.590-cvs/ChangeLog	2008-04-10 13:36:07.000000000 +0100
>+++ setup-2.590-rfl/ChangeLog	2008-04-10 14:08:16.090147800 +0100
>@@ -1,3 +1,8 @@
>+2008-04-10  Frank Lee  <>
>+	* Add command-line option '-s' to select software packages.
>+	* Intercept calls to message boxes if unattended flag (-q) is set.
>+	* Exit code IDS_REBOOT_REQUIRED is returned if needed.
> 2008-04-10  Brian Dessent  <>
> 	* (setup_LDFLAGS): Make sure static libbz2 and zlib

The above ChangeLog is not standard.  Just take a look at all of the other
entries in this file and you'll see things like it's missing a blank line after the
initial entry, it's missing filenames, and it is missing function names.  Also
the "voice" used is supposed to be active not passive, i.e., change:

	* Exit code IDS_REBOOT_REQUIRED is returned if needed.


	* (do_install_thread): Return exit code IDS_REBOOT_REQUIRED
	if needed.

See also: .


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]