This is the mail archive of the
cygwin-apps
mailing list for the Cygwin project.
Re: [PATCH] Propagate exit codes of scripts to setup
- From: Brian Dessent <brian at dessent dot net>
- To: cygwin-apps at cygwin dot com
- Date: Thu, 01 Sep 2005 09:47:24 -0700
- Subject: Re: [PATCH] Propagate exit codes of scripts to setup
- References: <Pine.GSO.4.61.0508191405310.16057@slinky.cs.nyu.edu>
Igor Pechtchanski wrote:
> As promised, here's a patch that makes Script::run() (and
> try_run_script()) return the exit code of the script. This just sets up
> the infrastructure -- the exit code is currently ignored (well, logged),
> but that could be changed later in both Installer::preremoveOne(),
> packagemeta::uninstall(), and do_postinstall_thread().
Thanks, applied. Although, I agree with Eric Blake's point that
postremove scripts are probably not a great idea, they're not documented
anywhere (that I know of), and the last package that used it has
switched to a preremove. Therefore I killed the postremove support
entirely.
Brian