This is the mail archive of the mailing list for the Cygwin project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[PATCH] setup: add "Size" column to chooser (take 2)

Here's a new iteration of this patch.  It incorporates Max's review and
adds comments in the size computation logic.

The size is now computed as follows: if the binary or the source package
is selected, the total size of the selected packages is used.  Otherwise,
the size of the binary package is shown (if one exists), else the size of
the source (if one exists), else "?".  As Max, I'm not sure this is the
right solution -- comments welcome.
P.S. The ChangeLog changed slightly -- new one below.
2005-05-24  Igor Pechtchanski  <>

	* PickView.h (PickView::size_col): New instance variable.
	* (pkg_headers, cat_headers): Add size column.
	(PickView::set_headers): Initialize size_col.
	(PickView::init_headers): Include width of size column.
	* (PickPackageLine::paint): Handle size_col.
	* (format_1000s): New function.
	* String++.h (format_1000s): Declare new function.

      |\      _,,,---,,_
ZZZzz /,`.-'`'    -.  ;-;;,_
     |,4-  ) )-,_. ,\ (  `'-'		Igor Pechtchanski, Ph.D.
    '---''(_/--'  `-'\_) fL	a.k.a JaguaR-R-R-r-r-r-.-.-.  Meow!

"The Sun will pass between the Earth and the Moon tonight for a total
Lunar eclipse..." -- WCBS Radio Newsbrief, Oct 27 2004, 12:01 pm EDT

Attachment: setup-package-size-column.patch
Description: Text document

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]