This is the mail archive of the cygwin-apps@cygwin.com mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Setup: hardlinks & percentages. (+patches)


Bas van Gompel schrieb:
Two little patches:

Maybe you want to add them to http://sources.redhat.com/bugzilla/enter_bug.cgi?product=cygwin
also.


When setup is making hardlinks, it doesn't use the prefixPath.
It is therefore just luck that hardlinks in normal packages ``work''.
Hardlinks in source-packages however don't, currently.
(case in point: rcs.)


2005-01-07 Bas van Gompel <patch-cygsup.buzz@bavag.tmfweb.nl>


	* archive.cc (archive::extract_file): Use prefixPath for linktarget
	on hardlinks.


--- setup/archive.cc 25 Dec 2004 23:05:56 -0000 2.10 +++ setup/archive.cc 7 Jan 2005 20:39:42 -0000 @@ -161,7 +161,7 @@ archive::extract_file (archive * source, io_stream::remove (destfilename); int ok = io_stream::mklink (destfilename, - prefixURL + source->linktarget (), + prefixURL + prefixPath + source->linktarget (), IO_STREAM_HARDLINK); /* FIXME: check what tar's filelength is set to for hardlinks */ source->skip_file ();


Then, when logging progress on reading inifiles, the percentages are displayed as single characters.

2005-01-07 Bas van Gompel <patch-cygsup.buzz@bavag.tmfweb.nl>

* ini.cc (class GuiParseFeedback): change type of lastpct.


--- setup/ini.cc 27 Dec 2004 16:12:43 -0000 2.39 +++ setup/ini.cc 7 Jan 2005 20:39:44 -0000 @@ -118,7 +118,7 @@ public: Progress.SetText4("Package:"); } private: - unsigned char lastpct; + unsigned int lastpct; };
--
Reini Urban
http://xarch.tu-graz.ac.at/home/rurban/


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]