This is the mail archive of the mailing list for the Cygwin project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Generic build script instructions

On Sat, 19 Jun 2004, Bas van Gompel wrote:

> Op Fri, 18 Jun 2004 09:04:42 -0400 (EDT) schreef Igor Pechtchanski:
> [...]
> : > +  ( exit ${STATUS} ) || exit ${STATUS}
> :       ^^^^^^^^^^^^^^^^^^
> : > +  shift
> : > +done
> :
> :  Do we really need a subshell here?  Isn't an "if" test enough (and more
> :  efficient)?
> Some thoughts. I did not do any testing on this.
> *) ``if test ${STATUS} -ne 0 ; then exit ${STATUS} fi'' does fork
>    a ``test'', doesn't it?
> *) ISTR ``autoconf'' generated ``configure''-s use a similar method.
> *) Most of the gbs-functions use a subshell ``(cd ${srcdir}...'';
> *) Relative to a configure, make or check this overhead should be
>    neglible.

Fair enough.  I realized after I sent it that one extra subshell won't
matter.  Never mind.

> :  P.S. I'm wondering whether I should ask for two separate patches, as they
> :  are independent and it's a bit hard to see the addition of "ispatch()"
> :  with the indentation adjustment...
> Hence the ``diff -b'' copy of the patch... If you decide I need to split
> this up, please let me know if you prefer any order of the patches, or
> should they be independant (from a common ancestor, for you to merge).
> l8r,
> Buzz.

I think I'd prefer the multiple parameters patch first, with its own
ChangeLog.  That part looks good enough to check in, actually.  As for the
"ispatch" part, let's discuss the name and the possible functionality (you
mentioned adding extra), and then it can be an add-on on top of the first
patch.  Frankly, I have reservations about the build script mucking with
anything outside of the build directory...

Thanks for contributing,
      |\      _,,,---,,_
ZZZzz /,`.-'`'    -.  ;-;;,_
     |,4-  ) )-,_. ,\ (  `'-'		Igor Pechtchanski, Ph.D.
    '---''(_/--'  `-'\_) fL	a.k.a JaguaR-R-R-r-r-r-.-.-.  Meow!

"I have since come to realize that being between your mentor and his route
to the bathroom is a major career booster."  -- Patrick Naughton

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]