This is the mail archive of the
mailing list for the Cygwin project.
Re: [Review - Good to go] suite3270
Harold L Hunt II wrote:
Peter A. Castro wrote:
I've fixed item #2 concerning the install phase of building. As
discussed, issue #1 will be left, as is, as it does not effect the
packaging process. If you would, please re-pull from the same URLs and
Okay, I just rebuilt the package. Here is my review:
Good to go!
The only question I have before uploading is how the files need to be
laid out. You gave a flat-file structure below, whereas we will
probably need something more like:
Ugh... I just noticed that your all command is as follows:
all) prep && conf && build && install && \
pkg && spkg && finish ; STATUS=$? ;;
You don't have a 'strip' command in there; I checked the s3270 package
and noticed that s3270.exe is 484 KiB, versus 170 KiB after running it
I suggest fixing this by adding 'strip' to the 'all' command and
re-running the 'all' command. I will upload the package tomorrow after
you have posted a stripped version.