This is the mail archive of the
mailing list for the Cygwin project.
RE: [SetupXP] The two styles for handling activation refusal
- From: "Gary R. Van Sickle" <g dot r dot vansickle at worldnet dot att dot net>
- To: <cygwin-apps at cygwin dot com>
- Date: Sun, 20 Jul 2003 12:54:29 -0500
- Subject: RE: [SetupXP] The two styles for handling activation refusal
> Gary's current SetupXP patchset calls 2 member functions on page activation:
> OnActivate (returns void), and OnAcceptActivation (returns bool). I think
> this is unnecessarily messy. AFAICS, OnAcceptActivation only exists to
> prevent the need to change the return type of the existing OnActivate
> I would very much prefer changing OnActivate to return bool, combining the
> purpose of both functions. Yes, this does require changes in all derived
> classes, but the changes are trivial, and the end result is a cleaner, more
> logical API.
That was exactly my originally-submitted patch. It was refused.
Gary R. Van Sickle