This is the mail archive of the mailing list for the Cygwin project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Preremove section in


Replies inline.

On 10 Jul 2003, Robert Collins wrote:

> Well, we haven't set a policy on the number of postinstall scripts.
> I'd really prefer one package == one script. It feels cleaner to me that
> way.

It's a general rule of thumb, but it's just a policy, not an
implementation limitation.  It might be cleaner sometimes to create
multiple postinstall scripts to clearly separate the functionality -- see
"base-files", for example.

> Also, it's not guaranteed that all your depended-upon scripts will run
> when a cycle is present.
> That is, if foo depends on bar, and bar on foo, only one of the two will
> have the scripts run first. Might be an idea to mention that (and the
> 'normal' approach of breaking the common stuff into a third package both
> depend on).

True.  I'll change that section.

> Pre remove scripts are limited to -one- per package. Either .sh or .bat.
> If setup supports both at once, it's an accident and is not guaranteed
> to remain.  Again, for consistency, all scripts should be one per
> package.

Pre-remove scripts are invoked using try_run_script(), which will execute
*both* .sh and .bat if present.

> Other than those issues, it looks good to me.
> Rob

Ok, I'm attaching another iteration.  Incidentally, what's the official
spelling of "postinstall" and "preremove"?  Is it with a hyphen, with a
space, or as one word?

> On Thu, 2003-07-10 at 12:25, Igor Pechtchanski wrote:
> > On Sat, 24 May 2003, Sergey Okhapkin wrote:
> >
> > > > Actually, all us package maintainers ought to do a better job
> > > > including "pre-remove" scripts in addition to post-install scripts,
> > > > that would clean up anything created by the postinstaller.  Yep --
> > > > setup supports this -- but most maintainers (I'm guilty here...) don't
> > > > bother:
> > >
> > > I never heard about "pre-remove" support in setup,
> > > has nothing about.
> >
> > Attached is a patch to <> that talks about
> > preremove scripts and brings the postinstall section up to date.  I'm
> > targeting it here rather than to the main cygwin list because IMO it is of
> > more interest to this audience, having to do with package maintenance and
> > setup.exe.  I can also check this in if it's approved.
> >       Igor

      |\      _,,,---,,_
ZZZzz /,`.-'`'    -.  ;-;;,_
     |,4-  ) )-,_. ,\ (  `'-'		Igor Pechtchanski, Ph.D.
    '---''(_/--'  `-'\_) fL	a.k.a JaguaR-R-R-r-r-r-.-.-.  Meow!

"I have since come to realize that being between your mentor and his route
to the bathroom is a major career booster."  -- Patrick Naughton

Attachment: setuphtml_postinstall_section.patch
Description: Text document

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]