This is the mail archive of the mailing list for the Cygwin project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: a2ps (Was Re: [UPDATE] Pending package status (06 May 2003))

>> On Wed, May 07, 2003 at 10:49:10AM -0400, Igor Pechtchanski wrote:
>>> Secondly, I thought
>>> <> (the fourth
>>> was a review (at least, it was written as such).
>>> If that's unacceptable, what constitutes a formal review?  Or do I
>>> need to update it for the latest posted release?

> On Wed, 7 May 2003, Christopher Faylor wrote:
>> That was certainly a formal enough review.  I didn't see any indication
>> your issues were rectified; at least not in that thread.  The CRLF issue,
>> least, deserves repackaging.

Igor Pechtchanski wrote:
> Chris,
> I thought this wasn't an issue after reading Max's reply (quoted below).
> However, upon re-reading, it's not clear whether his comment refers both
> to the CRLF issue and the tar permissions issue, or just the tar one.
> Max, care to comment?
>>> A few more nits:
>>> - The patch still has CRLF line endings.
>>> - The .tar.gz file extracted from the source archive has executable bits
>>> set.
> On Tue, 15 Apr 2003, Max Bowsher wrote:
>> This hasn't been rigourously checked for in the past.
>> Does it matter? If so, someone needs to patch the "Contributing" webpage.

I was just referring to the executable .tar.gz.

I do think CRLF patch needs fixing, and it wouldn't be a bad idea to fix up
the tar permissions at the same time.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]