This is the mail archive of the mailing list for the Cygwin project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Allow logging of {pre,post}remove scripts

On Tue, 2003-04-01 at 08:02, Igor Pechtchanski wrote:
> On 1 Apr 2003, Robert Collins wrote:
> > On Tue, 2003-04-01 at 02:42, Igor Pechtchanski wrote:
> > > Ping...
> > >       Igor
> >
> > Pong.
> >
> > Uhmm, try_run_script is always called with to_log true. So, why have the
> > parameter there at all?
> > Rob
> Umm, for symmetry?  If you ever wanted to turn off logging, all you'd have
> to do is change the calls.  By the same coin, run_script is never called
> without logging either...  If the decision were made to *always* do the
> logging, both parameters should be eliminated at the same time.
> 	Igor

Well, before when you where making changes to run_script, we where
migrating. Now, AFAICT all callers will use true, hard coded into the
source, to cause logging.

Thus, I;m suggesting that rather than propogate the to_log parameter
around, we simply making logging occur always.

If we decide we want different log targets (i.e. file, console,
/dev/null) then we won't have any obsolete code to cleanup at that


GPG key available at: <>.

Attachment: signature.asc
Description: This is a digitally signed message part

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]