This is the mail archive of the mailing list for the Cygwin project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

RE: [PATCH] Bigger Chooser 2

> On Sat, 2003-03-29 at 17:24, Gary R. Van Sickle wrote:
> > >
> > > it's too big for a single commit. I'd like you to start sending in the
> > > bits that you can, in a
> > > single-patch-does-a-single-conceptual-change style.
> > >
> > > Those I can review and approve for Max or I to checkin.
> > >
> >
> > Are you saying you won't review and approve this patch as-is?
> Yes. I've never liked 100K patches, even when I do them.

The source patch plus the new source file is only 50k total, at least 31k of
which is solely bigger-chooser (primarily res.rc, proppage.{cc,h},
propsheet.{cc,h}, Window.{cc,h}) and upon cursory examination simply is not
divisible.  Significant changes were required to implement this functionality,
and it just isn't something that can be checked in piecemeal and maintain a
working HEAD.

The other <19k is largely context around the one-liner OnActivate() changes you
mentioned, OnInit() one-liners, and miscellaneous other one-liners.  I don't
know if stripping these from the patch will result in a working or compilable
patch or not.  When I made these changes (OnActivate() intended to reduce the
"next page specified/controlled in several places" issue), setup patches were
not being reviewed and checked in in a timely manner, so I figured I'd do these
all at the same time since that's what I'd end up having to submit anyway.

And like I said, the new icon is just a bonus ;-).

So it's late, I'm babbling, wrap it up Gair.  Yes, there's two discernable
"conceptual" patches here (well, three if you count the icon which I hope you're
not counting): one's >31k of chooser enlargement, one's <19k of mostly
"diff -pu" context.  Yes, I sympathize with the "one patch / one concept"
philosophy (I think, don't quote me on that like I said it's late).  Yes, I have
no desire to split this into two patches (which sounds like a rather large
amount of unproductive work), and I don't see any size-related basis for doing

Gary R. Van Sickle
Brewer.  Patriot.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]