This is the mail archive of the cygwin-apps@cygwin.com mailing list for the Cygwin project.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
On 2 Feb 2003, Robert Collins wrote: > On Sun, 2003-02-02 at 07:37, Igor Pechtchanski wrote: > > > Yes, it does recompile everything when resource.h is modified, but that > > only happens once. A necessary evil... > > Even so... resource.h urrghh. > > > Sorry about the (null) bit. Should be fixed now. I also took your > > suggestion regarding "log file". The third iteration of the patch is > > attached... > > Igor > > ==================================== > > ChangeLog: > > 2002-10-17 Igor Pechtchanski <pechtcha@cs.nyu.edu> > > > > * res.rc (IDS_INSTALL_INCOMPLETE): Change hard-coded > > log filename to %s. > > (IDS_MISSING_LOG): New string resource. > > * resource.h (IDS_MISSING_LOG): New resource. > > * LogFile.cc (LogFile::exit): Pass log filename for > > LOG_BABBLE to note(). > > (LogFile::getFile): New function. > > * LogFile.h (LogFile::getFile): New function. > > getFile should be getFilename or getFileName. > > getFileName doesn't take a minlevel, it takes an exactLevel - your > parameter name is misleading, or you've got the logic in the loop wrong > :}. > > IDS_MISSING_LOG should be "No log was in use", not "setup.log.full". > It'll be ugly in the output, but at least accurate. > > Do those three changes, and I think this is ready. nice work guys. > > Rob Rob, I was mislead by the setFile() prototype. I agree with your proposed changes (and Max's use of angle brackets). Take four is attached. Thanks. Igor ====================================================================== ChangeLog: 2003-02-01 Igor Pechtchanski <pechtcha@cs.nyu.edu> * res.rc (IDS_INSTALL_INCOMPLETE): Change hard-coded log filename to %s. (IDS_MISSING_LOG): New string resource. * resource.h (IDS_MISSING_LOG): New resource. * LogFile.cc (LogFile::exit): Pass log filename for LOG_BABBLE to note(). (LogFile::getFileName): New function. * LogFile.h (LogFile::getFileName): New function. -- http://cs.nyu.edu/~pechtcha/ |\ _,,,---,,_ pechtcha@cs.nyu.edu ZZZzz /,`.-'`' -. ;-;;,_ igor@watson.ibm.com |,4- ) )-,_. ,\ ( `'-' Igor Pechtchanski '---''(_/--' `-'\_) fL a.k.a JaguaR-R-R-r-r-r-.-.-. Meow! Oh, boy, virtual memory! Now I'm gonna make myself a really *big* RAMdisk! -- /usr/games/fortune
Attachment:
setup-incomplete-message.patch
Description: Text document
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |