This is the mail archive of the
mailing list for the Cygwin project.
Re: [PATCH] Re: [setup] Inaccurate message: See /setup.log.full
Igor Pechtchanski wrote:
> Ping? (Just making sure this was seen).
> On Fri, 24 Jan 2003, Igor Pechtchanski wrote:
>> 2002-10-17 Igor Pechtchanski <firstname.lastname@example.org>
>> * res.rc (IDS_INSTALL_INCOMPLETE): Change hard-coded
>> log filename to %s.
>> * LogFile.cc (LogFile::exit): Pass log filename for
>> LOG_BABBLE to note().
>> (LogFile::getFile): New function.
>> * LogFile.h (LogFile::getFile): New function.
Definitely got here - I imagine Robert is just busy.
What do you think about the following suggestions ?
+static String bad_file = "the log";
+String const &
+LogFile::getFile (int minlevel) const
+ for (FileSet::iterator i = files.begin();
+ i != files.end(); ++i)
+ if (i->level == minlevel)
+ return i->key;
+ return bad_file;
just do: < return "the log"; >, and remove the bad_file variable?
+ String log_full = cygpath(getFile(LOG_BABBLE));
- note (NULL, exit_msg);
+ note (NULL, exit_msg, log_full.cstr_oneuse());
* note (NULL, exit_msg, cygpath(getFile(LOG_BABBLE)).cstr_oneuse());
Just a matter of personal opinion, really, so feel free to say "no" :-)