Re: [PATCH] debug/gdb: include expat for gdb-cross

[Trevor Woerner <twoerner at gmail dot com>]

Hi Yann,

Thanks for looking into this.

On Sun, Mar 3, 2013 at 9:02 AM, Yann E. MORIN <yann.morin.1998@free.fr> wrote:
> This is wrong:
>   - 'do_expat' is used to detect whether the expat lib shall be downloaded
>     and extracted;
>   - 'do_expat' is then mis-used:
>     - it is never used to build expat for the host, but is used to decide
>       whether to enable/disable expat in the cross-gdb
>     - it is used to decide whether to build expat for the target, but is
>       always set when the native-gdb is selected, so the check is pointless.

So if I understand you correctly, the only thing the build needs to
determine is if expat needs to be included in the sysroot?

> What should be done is:
>   - rename 'do_expat' to 'need_expat' (ditto for 'do_ncurses')
>   - use 'need_expat' only to decide whether to download/extract libexpat
>   - cross-gdb: always enable expat support
>   - native-gdb: ditto

In other words, if the build doesn't interfere with gdb's ./configure,
gdb's ./configure will naturally look for and link in the host's
expat?

Best regards,
    Trevor

--
For unsubscribe information see http://sourceware.org/lists.html#faq