Re: [PATCH] kernel/linux: change arch tuple to use -uclinux for uclinux toolchains

["Yann E. MORIN" <yann dot morin dot 1998 at free dot fr>]

Esben, All,

On Tuesday 25 September 2012 14:29:39 Esben Haabendal wrote:
> # HG changeset patch
> # User Esben Haabendal <esben.haabendal@prevas.dk>
> # Date 1348575902 -7200
> # Node ID 893b394644d2228baead66c2bb599f3ab1796a28
> # Parent  f46a1d105896c89f697ff7f2c8ebb6b7b8403d5d
> kernel/linux: change arch tuple to use -uclinux for uclinux toolchains
> 
> This fixes at least ColdFire uClinux builds, as gcc filters out
> all m68k no-mmu cpus for linux builds and (some) mmu cpus for uclinux
> builds.
> 
> Signed-off-by: "Esben Haabendal" <esben@haabendal.dk>
> 
> diff -r f46a1d105896 -r 893b394644d2 scripts/build/kernel/linux.sh
> --- a/scripts/build/kernel/linux.sh	Sun Sep 23 11:59:28 2012 +0900
> +++ b/scripts/build/kernel/linux.sh	Tue Sep 25 14:25:02 2012 +0200
> @@ -6,12 +6,7 @@
>      if [ "${CT_ARCH_USE_MMU}" = "y" ]; then
>          CT_TARGET_KERNEL="linux"
>      else
> -    # Sometime, noMMU linux targets have a -uclinux tuple, while
> -    # sometime it's -linux. We currently have only one noMMU linux
> -    # target, and it uses -linux, so let's just use that. Time
> -    # to fix that later...
> -    #    CT_TARGET_KERNEL="uclinux"
> -        CT_TARGET_KERNEL="linux"
> +        CT_TARGET_KERNEL="uclinux"
>      fi
>  }

NAK.

IIRC, the blackfin arch does not use '-uclinux', but '-linux':

    $ hg blame scripts/build/kernel/linux.sh
    [--SNIP--]
    1345: CT_DoKernelTupleValues() {
    1345:     if [ "${CT_ARCH_USE_MMU}" = "y" ]; then
    1345:         CT_TARGET_KERNEL="linux"
    1345:     else
    1910:     # Sometime, noMMU linux targets have a -uclinux tuple, while
    1910:     # sometime it's -linux. We currently have only one noMMU linux
    1910:     # target, and it uses -linux, so let's just use that. Time
    1910:     # to fix that later...
    1910:     #    CT_TARGET_KERNEL="uclinux"
    1910:         CT_TARGET_KERNEL="linux"
    1345:     fi
    1345: }
    [--SNIP--]

    $ hg log -v -r 1910 --template '{desc}\n'
    Add basic support for the Blackfin architecture
    [--SNIP--]
    Apply the patch to the kernel/linux build script to use 'linux'
    in the noMMU tuples. See:
      http://sourceware.org/ml/crossgcc/2010-04/msg00010.html

Basically, 'bfin-elf' is for bare-metal, 'bfin-uclinux' if for flat-binaries
with no shared libs, and 'bfin-linux' for FDPIC-ELF that allows shared libs.

So, if there are archs that want -uclinux, it has to be conditional.

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

--
For unsubscribe information see http://sourceware.org/lists.html#faq