Re: [PATCH] Keep an uncompressed build log

["Yann E. MORIN" <yann dot morin dot 1998 at anciens dot enib dot fr>]

Trevor, All,

Sorry for the delay, as you can see, there has been quite some disussions
tonight! :-)

On Thursday 03 March 2011 07:47:20 Trevor Woerner wrote:
> Keep an uncompressed build log.
> 
> After the build has completed, retain a copy of the uncompressed build log
> in the build directory (${CT_TOP_DIR}) in addition to the compressed copy
> at the install location (${CT_PREFIX_DIR}).
> 
> diff -r 046b36207331 -r 77ce48248e12 scripts/crosstool-NG.sh.in
> --- a/scripts/crosstool-NG.sh.in	Sun Feb 27 22:14:12 2011 +0100
> +++ b/scripts/crosstool-NG.sh.in	Thu Mar 03 01:24:20 2011 -0500
> @@ -624,6 +624,7 @@
>  CT_DoLog INFO "Finishing installation (may take a few seconds)..."
>  exec >/dev/null 2>&1
>  
> +cp ${CT_LOG_FILE} ${CT_TOP_DIR}

Enclose variables in double-quotes.
Normally, there are no spaces in the directory crosstool-NG handles (a check
is done to avoid that), but you never know... And it's good practice anyway
to enclose user-supplied variables in double-quotes.

>  [ "${CT_LOG_FILE_COMPRESS}" = y ] && bzip2 -9 "${CT_LOG_FILE}"
>  [ "${CT_INSTALL_DIR_RO}" = "y"  ] && chmod -R a-w "${CT_INSTALL_DIR}"
>  [ "${CT_TEST_SUITE}" = "y" ] && chmod -R u+w "${CT_TEST_SUITE_DIR}"

In fact, I'd suggest the oposite: have the build.log file be in the working
directory. Then, once the toolchain is successfully built, save a compressed
copy in the toolchain install dir.

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

--
For unsubscribe information see http://sourceware.org/lists.html#faq