This is the mail archive of the
cgen@sources.redhat.com
mailing list for the CGEN project.
Problem with keyword parsing for gas
- From: "Nick Kelsey" <nickk at ubicom dot com>
- To: <cgen at sources dot redhat dot com>
- Date: Tue, 17 Dec 2002 18:02:52 -0800
- Subject: Problem with keyword parsing for gas
- Reply-to: "Nick Kelsey" <nickk at ubicom dot com>
Hi guys,
A change was made to cgen in mid 2001 that affects keyword parsing....
opcodes/cgen-asm.c (early 2001): cgen_parse_keyword:
/* Now allow letters, digits, and _. */
while (((p - start) < (int) sizeof (buf))
&& (isalnum ((unsigned char) *p) || *p == '_'))
++p;
This would correctly treat <keyword>_temp as a non keyword.
The new code reads as follows:
/* Allow letters, digits, and any special characters. */
while (((p - start) < (int) sizeof (buf))
&& *p
&& (ISALNUM (*p) || strchr (keyword_table->nonalpha_chars, *p)))
++p;
This does not treat an underscore as a symbol character and gas barfs on a
symbol that starts <keyword>underscore.
Possible solutions that spring to mind... Add an explicit check for
underscore to the while statement, or add an underscore to nonalpha_chars.
Adding an underscore to nonalpha_chars is easy as it is global and
pre-initialized...
CGEN_KEYWORD xxx_cgen_opval_register_names =
{
& xxx_cgen_opval_register_names_entries[0],
121,
0, 0, 0, 0, "_"
};
However this is generated code so there are bigger implications.
I am completly open to suggestions and implications as to the best way to
fix this without breaking other ports.
Thanks
Nick