[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: bzip2 1.0.7 released
On Fri, 2019-06-28 at 00:46 +0200, Mark Wielaard wrote:
> So it looks like some implementations might add more selectors than
> necessary. For example lbzip2 seems to use a max of 18000 + 1 + 7.
> Which might explain why our 18002 = 2 + (900000 / 50) isn't enough,
> why my random increase of 5 seemed to work for the given file.
> In general the nSelector field can be up to 15 bits, so 32768. So we
> definitely do want to check the input doesn't overflow (or make
> BZ_MAX_SELECTORS 32768, but that seems excessive).
I've posted a little more analysis here: