This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] binutils: doc: move back binutils.info to MAINTAINERCLEANFILES
- From: Alan Modra <amodra at gmail dot com>
- To: Simon Marchi <simon dot marchi at efficios dot com>
- Cc: binutils at sourceware dot org
- Date: Sat, 7 Mar 2020 09:49:26 +1030
- Subject: Re: [PATCH] binutils: doc: move back binutils.info to MAINTAINERCLEANFILES
- References: <20200306162556.14085-1-simon.marchi@efficios.com>
On Fri, Mar 06, 2020 at 11:25:56AM -0500, Simon Marchi wrote:
> In commit 2b44a6a237 (" binutils: doc: make `make clean` clean more
> things"), I moved binutils.info to the MOSTLYCLEANFILES, which made it
> get removed by "make clean".
>
> Because generating binutils.info requires makeinfo, and we do not want
> to require makeinfo when building from the tarball, binutils.info should
> not get removed by "make clean" (otherwise, it won't be included in the
> tarball).
>
> This patch puts it back in MAINTAINERCLEANFILES, so that it only gets
> cleaned if you use "make maintainer-clean".
>
> Tested by building a source release and confirming that binutils.info is
> present.
It's not just binutils.info but also all the .1 files. I think you
should move $(man_MANS) to MAINTAINERCLEANFILES too. src-release.sh
does a "make distclean" when preparings sources for a tar file.
> binutils/ChangeLog:
>
> PR 25491
> * doc/Makefile.am: Move binutils.info to MAINTAINERCLEANFILES.
> * doc/Makefile.in: Re-generate.
OK with man_MANS moved too.
--
Alan Modra
Australia Development Lab, IBM