Re: [PATCH 7/9] x86: fold (supposed to be) identical code

["H.J. Lu" <hjl dot tools at gmail dot com>]

On Wed, Mar 4, 2020 at 1:40 AM Jan Beulich <jbeulich@suse.com> wrote:
>
> The Q and L suffix exclusion checks in match_template() ought to be
> (kept) in sync as far as their FPU and SIMD aspects go. This was
> already violated by only the Q one checking for active broadcast.
> Convert the code such that there'll be only one instance of the logic,
> the more that subsequently the logic is liable to need further
> refinement / extension. (The alternative would be to drop all SIMD-ness
> from the L part, but it is in principle possible to enable all sorts of
> SIMD support with just a pre-386 CPU, via suitable .arch directives.)
>
> gas/
> 2020-03-XX  Jan Beulich  <jbeulich@suse.com>
>
>         * config/tc-i386.c (match_template): Fold duplicate code in
>         logic rejecting certain suffixes in certain modes. Drop
>         pointless "else".
>

OK.

Thanks.

-- 
H.J.