Re: [PATCH 2/9] x86: add missing IgnoreSize

["H.J. Lu" <hjl dot tools at gmail dot com>]

On Wed, Mar 4, 2020 at 1:37 AM Jan Beulich <jbeulich@suse.com> wrote:
>
> For proper code generation in 16-bit mode (or to avoid the "same type of
> prefix used twice" diagnostic there), IgnoreSize is needed on certain
> templates allowing for just 32-(and maybe 64-)bit operands.
>
> Beyond adding tests for the previously broken cases, also add ones for
> the previously working cases where IgnoreSize is needed for the same
> reason (leaving out MPX for now, as that'll require an assembler change
> first). Some minor adjustments to tests get done such that re-use of the
> same code for 16-bit code generation testing becomes easier.
>
> gas/
> 2020-03-XX  Jan Beulich  <jbeulich@suse.com>
>
>         * testsuite/gas/i386/adx.s, testsuite/gas/i386/cet.s,
>         testsuite/gas/i386/ept.s, testsuite/gas/i386/fsgs.s,
>         testsuite/gas/i386/invpcid.s, testsuite/gas/i386/movdir.s,
>         testsuite/gas/i386/ptwrite.s, testsuite/gas/i386/vmx.s,
>         testsuite/gas/i386/waitpkg.s: Re-assemble some of the source as
>         16-bit code.
>         * testsuite/gas/i386/code16.s: Add CR, DR, and TR access cases
>         as well as a BSWAP one.
>         * testsuite/gas/i386/rdpid.s: Add 16-bit case.
>         * testsuite/gas/i386/sse2-16bit.s: Cover more insns.
>         * testsuite/gas/i386/adx-intel.d, testsuite/gas/i386/adx.d,
>         testsuite/gas/i386/cet-intel.d, testsuite/gas/i386/cet.d,
>         testsuite/gas/i386/code16.d, testsuite/gas/i386/ept-intel.d,
>         testsuite/gas/i386/ept.d, testsuite/gas/i386/fsgs-intel.d,
>         testsuite/gas/i386/fsgs.d, testsuite/gas/i386/invpcid-intel.d,
>         testsuite/gas/i386/invpcid.d, testsuite/gas/i386/movdir-intel.d,
>         testsuite/gas/i386/movdir.d, testsuite/gas/i386/ptwrite-intel.d,
>         testsuite/gas/i386/ptwrite.d, testsuite/gas/i386/rdpid-intel.d,
>         testsuite/gas/i386/rdpid.d, testsuite/gas/i386/sse2-16bit.d,
>         testsuite/gas/i386/vmx.d, testsuite/gas/i386/waitpkg-intel.d,
>         testsuite/gas/i386/waitpkg.d: Adjust expectations.
>
> opcodes/
> 2020-03-XX  Jan Beulich  <jbeulich@suse.com>
>
>         * i386-opc.tbl (movmskps, mwait, vmread, vmwrite, invept,
>         invvpid, invpcid, rdfsbase, rdgsbase, wrfsbase, wrgsbase, adcx,
>         adox, mwaitx, rdpid, movdiri): Add IgnoreSize.
>         (ptwrite): Split into non-64-bit and 64-bit forms.
>         * i386-tbl.h: Re-generate.
>

OK.

Thanks.

-- 
H.J.