This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [ld] section address : ALIGN(align) and the maximum of input section alignments
- From: Fangrui Song <i at maskray dot me>
- To: Alan Modra <amodra at gmail dot com>
- Cc: binutils <binutils at sourceware dot org>, smithp352 at googlemail dot com
- Date: Tue, 3 Mar 2020 22:39:45 -0800
- Subject: Re: [ld] section address : ALIGN(align) and the maximum of input section alignments
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=maskray.me; dmarc=pass action=none header.from=maskray.me; dkim=pass header.d=maskray.me; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=u9htUAthmkWg9Dex8Frq6ns4hW+6xQIoHa20Ut/RQMg=; b=TVA4VYwYE+th+hdLIWt78L+wBeQ4nZ8W1lubL81A4r8xu81KlfF1quhCKHHCfMFQpI+/2PkqzINCBK+cWEqI10GsG6kqtEXg4o54MuDjpgOpk/W5vvXEgiy8epweyhhMr7D0qWnwHgCUAx2gttU5PT1g6TvNoh8iRwsaJl8vOUHpfF2vgb85iKbiOtEL/UfbAPUhRV3J7xHl+GXEc4gdKejdBNDGYXJNxzMLWVKw3OKOUFolCFTd+kecKsocB9QHJzRcSzR1Ay/glM6OaMysp+TdAwf998Hy/MnwliptLFcXx9JY3CwT9w6ExoX4Vf7RqyPuaU3kuDHW2K0alw1zrw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PSqg0OyygwG4iWaOP2/YH194vBASxuk5MC4efgOWOMefPhX5q3txXFXxzErI9BtqXmNKtzebi7G6jM4H6Rk6xYzUmVyl+B++VaS39j/cTAXSVfESo/3XjFDyQCnlHlwsaEKdO3fkGlkg5mFGb72057gcB8z3GXWryOh9cBe9s057A77dJ2chXD1DnlaVqwQ8VF2dgye+kiYxGrm3tcRtj3GQ9LooeJib1MOvjwxfV9X0Ne7kvVyRz+kMKWU7XpxEbYpf0JVYSzZjF1WId4PFNifTBylamtWc0JfD6PA0LFpEqHjAVVjgLYaVgMoGZu90598nGnlRy03KvzaPt1eIOw==
- References: <20200226052300.wazzfmivxta63vef@gmail.com> <20200226063003.4uvshiarho3wbkrl@google.com> <20200303223901.GO5384@bubble.grove.modra.org> <BY5PR07MB7316674DD98011D2AD812A63CBE40@BY5PR07MB7316.namprd07.prod.outlook.com> <20200304055641.GT5384@bubble.grove.modra.org>
On Tue, Mar 3, 2020 at 9:56 PM Alan Modra <amodra@gmail.com> wrote:
>
> On Tue, Mar 03, 2020 at 03:58:12PM -0800, Fangrui Song wrote:
> > Thanks. For the example below, do you agree with the comments in a.x below?
> >
> > % cat a.s
> > .globl _start; _start: ret
> > .section .data.rel.ro,"aw"; .balign 8; .byte 0
> > .data; .byte 0
> > .section .data2,"aw"; .balign 8; .byte 0
> > .section .data3,"aw"; .balign 32; .byte 0
> > .bss; .balign 32; .byte 0
> > % as a.s -o a.o
> >
> > % cat a.x
> > SECTIONS {
> > .text 0x10000 : { *(.text) }
> > /* sh_addr is 0x10010. Specifying both address and ALIGN should be
> > disallowed. */
> > .data.rel.ro . : ALIGN(16) { *(.data.rel.ro) }
> >
> > .data 0x20000 : { *(.data) }
> > /* sh_addr is 0x20001. Should there be a warning that sh_addralign
> > is 8? Even --warn-section-align does not warn. */
>
> That is a bug.
>
> The ELF gABI says in part of sh_addralign: "The value of sh_addr must
> be congruent to 0, modulo the value of sh_addralign."
>
> * elf.c (elf_fake_sections): Ensure sh_addralign is such that
> sh_addr mod sh_addalign is zero.
>
> diff --git a/bfd/elf.c b/bfd/elf.c
> index fcd84d2d17..c4d6718aaa 100644
> --- a/bfd/elf.c
> +++ b/bfd/elf.c
> @@ -3192,6 +3192,7 @@ elf_fake_sections (bfd *abfd, asection *asect, void *fsarg)
> unsigned int sh_type;
> const char *name = asect->name;
> bfd_boolean delay_st_name_p = FALSE;
> + bfd_vma mask;
>
> if (arg->failed)
> {
> @@ -3291,7 +3292,10 @@ elf_fake_sections (bfd *abfd, asection *asect, void *fsarg)
> arg->failed = TRUE;
> return;
> }
> - this_hdr->sh_addralign = (bfd_vma) 1 << asect->alignment_power;
> + /* Set sh_addralign to the highest power of two given by alignment
> + consistent with the section VMA. Linker scripts can force VMA. */
> + mask = ((bfd_vma) 1 << asect->alignment_power) | this_hdr->sh_addr;
> + this_hdr->sh_addralign = mask & -mask;
> /* The sh_entsize and sh_info fields may have been set already by
> copy_private_section_data. */
>
>
> > .data2 . : { *(.data2) }
> > /* sh_addr is 0x20020. The input section alignment wins. */
> > .data3 : ALIGN(16) { *(.data3) }
> > /* sh_addr is 0x20030. Specifying both address and ALIGN should be
> > disallowed. */
> > .bss . : ALIGN(16) { *(.bss) }
> > }
> >
> > % ld.bfd -T a.x a.s -o a
> >
> > If specifying both Output Section Address and ALIGN is disallowed,
> > there should be no "changing start of section" warning when
> > --warn-section-align is not specified. Is my understanding correct?
> >
> > BTW, I filed a bug about duplicate "changing start of section"
> > warnings https://sourceware.org/bugzilla/show_bug.cgi?id=25570
The implementation is complex. For users to understand, I think it
will be helpful to have something more detailed in
https://sourceware.org/binutils/docs/ld/Output-Section-Address.html#Output-Section-Address
If my understanding is correct
https://sourceware.org/git/?p=binutils-gdb.git;a=commit;h=233bf4f847b136705247e2f7f11bae41c72448a4
makes the output section address override sh_addralign computed from
the maximum of input section alignments. So, generally the rules are:
* The max of ALIGN and (the maximum of input section alignments) is taken.
* The output section address overrides the above. If sh_addr %
alignment != 0, set sh_addralign to the largest alignment that makes
sh_addr%alignment=0
In this case, should the linker emit a warning?
* ALIGN and the output section address cannot be specified at the same
time. This is considered a linker script "undefined behavior". Users
should not rely on a particular result.
--warn-section-align may be out of place. It can be noisy for normal
output section descriptions like .foo : ALIGN(16) { ... } without
a preceding dot advancing to a multiple of 16.