This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: Committing patches for other people

From: Eric Christopher <echristo at gmail dot com>
To: Alan Modra <amodra at gmail dot com>
Cc: binutils at sourceware dot org
Date: Wed, 19 Feb 2020 15:35:36 -0800
Subject: Re: Committing patches for other people
References: <20200214201441.146590-1-rupprecht@google.com> <20200219090334.GR5570@bubble.grove.modra.org> <CALehDX4Nz6Z=eBypKLeouDg3RJyc2uPnnnLVeWdj5zqMAN0VCw@mail.gmail.com> <20200219225503.GV5570@bubble.grove.modra.org>

Ah yes that's a very good point.

On Wed, Feb 19, 2020, 2:55 PM Alan Modra <amodra@gmail.com> wrote:

> On Wed, Feb 19, 2020 at 01:58:20PM -0800, Eric Christopher wrote:
> > I've gone ahead and committed this for Jordan.
>
> OK, but I'll note that when not using "git am" to commit other
> people's patches you should take steps to properly attribute
> authorship.
>   git commit --amend --author="Joe Bloe <joe@somewhere.net>"
>
> As it is, "git blame" shows
> 741cb83912f (Eric Christopher  2020-02-19 13:55:25 -0800
> for objdump.c lines changed by Jordan's patch.
>
> None of this matters very much at the moment, but if we are to move
> away from ChangeLogs then we will need to learn better habits.
>
> --
> Alan Modra
> Australia Development Lab, IBM
>

References:
- [PATCH] Demangle names when using --line-numbers --disassemble.
  - From: Jordan Rupprecht via binutils
- Re: [PATCH] Demangle names when using --line-numbers --disassemble.
  - From: Alan Modra
- Re: [PATCH] Demangle names when using --line-numbers --disassemble.
  - From: Eric Christopher
- Committing patches for other people
  - From: Alan Modra

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]