This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] plugin: Call dlclose before return in try_load_plugin


On Wed, Feb 19, 2020 at 3:35 AM H.J. Lu <hjl.tools@gmail.com> wrote:
>
> On Tue, Feb 18, 2020 at 8:59 PM Alan Modra <amodra@gmail.com> wrote:
> >
> > On Tue, Feb 18, 2020 at 04:50:16AM -0800, H.J. Lu wrote:
> > > Since plugin can be used only once in try_load_plugin, call dlclose
> > > before return.
> > >
> > > OK for master and 2.34 branch?
> > >
> > >       PR binutils/25355
> > >       * plugin.c (plugin_list_entry): Remove handle.
> > >       (try_load_plugin): Call dlclose before return.
> >
> > Looks OK to me.
> >
>
> This is the patch I am checking in.  It kept
>
>   if (current_plugin)
>     memset (current_plugin, 0,
>                    offsetof (struct plugin_list_entry, next));
>

Hi Nick,

Is it OK for backport to 2.34 branch?

-- 
H.J.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]