This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [committed, PATCH] x86: Don't disable SSE4a when disabling SSE4

From: Alan Modra <amodra at gmail dot com>
To: "H.J. Lu" <hjl dot tools at gmail dot com>
Cc: Jan Beulich <jbeulich at suse dot com>, "binutils at sourceware dot org" <binutils at sourceware dot org>
Date: Mon, 17 Feb 2020 11:36:28 +1030
Subject: Re: [committed, PATCH] x86: Don't disable SSE4a when disabling SSE4
References: <3bc597bb-10f9-80f9-8e00-f28aeb2eea77@suse.com> <CAMe9rOprBKRvUA5=KANDewxtdc+-N=1R7DnziB8x=LiW9TECsA@mail.gmail.com> <CAMe9rOrfhifWFpVKh8i37x6LY8ggkALK8ck4BcLxnT5P616rpA@mail.gmail.com>

On Sun, Feb 16, 2020 at 08:47:56AM -0800, H.J. Lu wrote:
> commit 7deea9aad8 changed nosse4 to include CpuSSE4a.  But AMD SSE4a is
> a superset of SSE3 and Intel SSE4 is a superset of SSSE3.  Disable Intel
> SSE4 shouldn't disable AMD SSE4a.  This patch restores nosse4.  It also
> adds .sse4a and nosse4a.

diff --git a/opcodes/i386-gen.c b/opcodes/i386-gen.c
index 79f4cc9d25..45106bcf6d 100644
--- a/opcodes/i386-gen.c
+++ b/opcodes/i386-gen.c
@@ -326,6 +326,8 @@ static initializer cpu_flag_init[] =
   { "CPU_ANY_SSE2_FLAGS",
     "CPU_ANY_SSE3_FLAGS|CpuSSE2" },
   { "CPU_ANY_SSE3_FLAGS",
+  { "CPU_ANY_SSE4A_FLAGS",
+    "CPU_ANY_SSE3_FLAGS|CpuSSE4a" },
     "CPU_ANY_SSSE3_FLAGS|CpuSSE3|CpuSSE4a" },
   { "CPU_ANY_SSSE3_FLAGS",
     "CPU_ANY_SSE4_1_FLAGS|CpuSSSE3" },
@@ -333,8 +335,6 @@ static initializer cpu_flag_init[] =
     "CPU_ANY_SSE4_2_FLAGS|CpuSSE4_1" },
   { "CPU_ANY_SSE4_2_FLAGS",
     "CpuSSE4_2" },
-  { "CPU_ANY_SSE4_FLAGS",
-    "CPU_ANY_SSE4_1_FLAGS|CpuSSE4a" },
   { "CPU_ANY_AVX_FLAGS",
     "CPU_ANY_AVX2_FLAGS|CpuF16C|CpuFMA|CpuFMA4|CpuXOP|CpuAVX" },
   { "CPU_ANY_AVX2_FLAGS",

Merge error?

-- 
Alan Modra
Australia Development Lab, IBM

Follow-Ups:
- Re: [committed, PATCH] x86: Don't disable SSE4a when disabling SSE4
  - From: H.J. Lu

References:
- [PATCH] x86: fix SSE4a dependencies of ".arch .nosse*"
  - From: Jan Beulich
- Re: [PATCH] x86: fix SSE4a dependencies of ".arch .nosse*"
  - From: H.J. Lu
- [committed, PATCH] x86: Don't disable SSE4a when disabling SSE4
  - From: H.J. Lu

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]