This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] [binutils/testsuite] debuginfod.exp: Improve port selection
- From: Andreas Schwab <schwab at suse dot de>
- To: Aaron Merey <amerey at redhat dot com>
- Cc: binutils at sourceware dot org
- Date: Thu, 13 Feb 2020 09:42:18 +0100
- Subject: Re: [PATCH] [binutils/testsuite] debuginfod.exp: Improve port selection
- References: <CAJDtP-S45N-_fbsFtiMAKZH+=XzzrLTRNuNxN8qvJkJ79OZfDA@mail.gmail.com>
On Feb 12 2020, Aaron Merey wrote:
> @@ -99,34 +96,36 @@ file delete -force $db
> set conf_objdump [binutils_run $OBJDUMP "-WK tmpdir/testprog"]
> set conf_readelf [binutils_run $READELF "-wK tmpdir/testprog"]
>
> -set debuginfod_pid 0
> -
> -# Kill the server if we abort early
> -proc sigint_handler {} {
> - global debuginfod_pid
> +# Find an unused port
> +set port 7999
> +set found 0
> +while { ! $found } {
> + incr port
> + if { $port == 65536 } {
> + fail "$test (no available ports)"
That should be unsupported or untested, not fail.
Andreas.
--
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."