This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH v3 2/4] RISC-V: Support the ISA-dependent CSR checking.
- From: Nelson Chu <nelson dot chu at sifive dot com>
- To: Jim Wilson <jimw at sifive dot com>
- Cc: Binutils <binutils at sourceware dot org>
- Date: Tue, 4 Feb 2020 15:14:59 +0800
- Subject: Re: [PATCH v3 2/4] RISC-V: Support the ISA-dependent CSR checking.
- References: <1576473701-11072-1-git-send-email-nelson.chu@sifive.com> <1576473701-11072-3-git-send-email-nelson.chu@sifive.com> <CAFyWVaattSuSgny04y1FOxHH_V5ivRP5M3-gyy=vpTSA4WcJsg@mail.gmail.com>
Hi Jim,
On Sat, Feb 1, 2020 at 9:26 AM Jim Wilson <jimw@sifive.com> wrote:
>
> Overall, this one looks OK to me.
Thank you very much :)
> But there are gdb changes that require gdb review and approval. It is
> OK to send an email to both binutils and gdb-patches at the same time
> when it needs approval from both. And unfortunately I'm not a gdb
> reviewer but I can give a thumbs up on the gdb patches.
OK, I will remove the first patch and then send the new series of
patches to both binutils and gdb.
> I see some functions missing comments. This is a minor problem, but I
> think the style guidelines still require an explanatory comment before
> each function.
No problem, I will fix this.
> When I ran the testsuite for a riscv64-elf target, the csr-dw-regnums
> test fails.
> /home/jimw/FOSS/BINUTILS/binutils-gdb/gas/testsuite/gas/riscv/csr-dw-regnums.s:53:
> Error: unknown register `cycleh'
> followed by a lot of similar errors. This will need to use
> -march=rv32if as is already done with priv-reg-all.d.
Oh I test the regressions after attaching the whole series of patches.
Thanks for your remind, I will fix this in the next version.
Thanks
Nelson