This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] binutils: drop redundant 'program_name' definition (-fno-common)
- From: Alan Modra <amodra at gmail dot com>
- To: Sergei Trofimovich <slyfox at gentoo dot org>
- Cc: binutils at sourceware dot org, Sergei Trofimovich <siarheit at google dot com>
- Date: Mon, 3 Feb 2020 16:00:03 +1030
- Subject: Re: [PATCH] binutils: drop redundant 'program_name' definition (-fno-common)
- References: <20200201231611.264009-1-slyfox@gentoo.org>
On Sat, Feb 01, 2020 at 11:16:11PM +0000, Sergei Trofimovich wrote:
> From: Sergei Trofimovich <siarheit@google.com>
>
> On gcc-10 (and gcc-9 -fno-common) --enable-targets=all build fails as:
> ```
> libtool: link: gcc ... -o srconv srconv.o bucomm.o ...
> ld: bucomm.o:(.bss+0x0):
> multiple definition of `program_name'; srconv.o:(.bss+0x0): first defined here
> collect2: error: ld returned 1 exit status
> make[4]: *** [Makefile:942: srconv] Error 1
> ```
>
> * binutils/coffdump.c (program_name): drop redundant definition.
> * binutils/srconv.c (program_name): drop redundant definition.
> * binutils/sysdump.c (program_name): drop redundant definition.
Applied.
--
Alan Modra
Australia Development Lab, IBM