This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: Recent change causing s390x binutils builds to fail
- From: Jeff Law <law at redhat dot com>
- To: Nick Clifton <nickc at redhat dot com>, "binutils at sourceware dot org" <binutils at sourceware dot org>
- Date: Fri, 31 Jan 2020 09:59:49 -0700
- Subject: Re: Recent change causing s390x binutils builds to fail
- References: <040536c10c8e58ee91cb68f1c885136354a4676d.camel@redhat.com> <1e54626a-a984-acd0-a551-586e438a1231@redhat.com>
- Reply-to: law at redhat dot com
On Fri, 2020-01-31 at 16:43 +0000, Nick Clifton wrote:
> Hi Jeff,
>
> > Somewehre between a2236a08440996fe2adb5f9b61926db9a9e8c8c3
> > and 0c115f8483ac32dc95fde902cac8c8bb99f9c3be s390x native builds have
> > started failing.
> >
> > > ../../../binutils/gas/config/tc-s390.c:899:10: error: implicit conversion from ‘enum bfd_reloc_code_real’ to ‘elf_suffix_type’ [-Werror=enum-conversion]
> > > 899 | return BFD_RELOC_UNUSED;
>
> I think that was due to a simple thinko on the contributor's
> part. I have checked in what I hope is the obvious patch to
> fix the problem.
>
> Cheers
> Nick
>
> gas/ChangeLog
> 2020-01-31 Nick Clifton <nickc@redhat.com>
>
> * config/tc-s390.c (s390_elf_suffix): Return ELF_SUFFIX_NONE
> rather than BFD_RELOC_NONE.
THanks. I'll fire off a build in the tester. If you don't hear from
me, assume it went fine.
jeff
>