This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] x86: prevent undue use of GOT32X and alike relocations
- From: "H.J. Lu" <hjl dot tools at gmail dot com>
- To: Jan Beulich <jbeulich at suse dot com>
- Cc: "binutils at sourceware dot org" <binutils at sourceware dot org>
- Date: Thu, 30 Jan 2020 03:29:18 -0800
- Subject: Re: [PATCH] x86: prevent undue use of GOT32X and alike relocations
- References: <5f738ed0-d07b-dadb-0144-65038702b34b@suse.com>
On Thu, Jan 30, 2020 at 2:49 AM Jan Beulich <jbeulich@suse.com> wrote:
>
> Comparison of i.tm.base_opcode against particular but not sufficiently
> specific values needs to be accompanied by other qualification. Exclude
> VEX and alike encodings here, and also exclude all forms of prefixes
> explicitly specified in the opcodes table. While using @GOT with such
> insns may not be very useful, it also isn't with e.g. ADC and SBB, yet
> these get explicitly listed in comments as supported.
>
> gas/
> 2020-01-XX Jan Beulich <jbeulich@suse.com>
>
> * config/tc-i386.c (output_disp): Tighten base_opcode check.
> * testsuite/gas/i386/got.s: Add LSL, MOVLPS, and BNDCN cases.
> * testsuite/gas/i386/got-no-relax.d, testsuite/gas/i386/got.d:
> Adjust expectations.
>
OK.
Thanks.
--
H.J.