This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 3/3] Identify reproducible builds in 'objdump -p' output for PE files

From: Alan Modra <amodra at gmail dot com>
To: Jon Turney <jon dot turney at dronecode dot org dot uk>
Cc: binutils at sourceware dot org
Date: Wed, 29 Jan 2020 08:48:20 +1030
Subject: Re: [PATCH 3/3] Identify reproducible builds in 'objdump -p' output for PE files
References: <20200121155212.12686-1-jon.turney@dronecode.org.uk> <20200121155212.12686-4-jon.turney@dronecode.org.uk>

On Tue, Jan 21, 2020 at 03:52:12PM +0000, Jon Turney wrote:
> 	* peXXigen.c (pe_is_repro): New function.
> 	(_bfd_XX_print_private_bfd_data_common): Note timestamp is
> 	actually a build hash if PE_IMAGE_DEBUG_TYPE_REPRO is present.

OK, except

> +  if ((section == NULL) ||
> +      (!(section->flags & SEC_HAS_CONTENTS)) ||
> +      (section->size < size))

Please fix the trailing operators.

  if (section == NULL
      || !(section->flags & SEC_HAS_CONTENTS)
      || section->size < size)

-- 
Alan Modra
Australia Development Lab, IBM

Follow-Ups:
- Re: [PATCH 3/3] Identify reproducible builds in 'objdump -p' output for PE files
  - From: Jon Turney

References:
- [PATCH 0/3] Identify reproducible build PE files in 'objdump -p'
  - From: Jon Turney
- [PATCH 3/3] Identify reproducible builds in 'objdump -p' output for PE files
  - From: Jon Turney

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]