This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH roland/objcopy-merge-notes-qsort] Fix objcopy --merge-notes dependency on qsort implementation behavior.
- From: "Roland McGrath via binutils" <binutils at sourceware dot org>
- To: Nick Clifton <nickc at redhat dot com>
- Cc: Binutils <binutils at sourceware dot org>
- Date: Mon, 27 Jan 2020 11:19:17 -0800
- Subject: Re: [PATCH roland/objcopy-merge-notes-qsort] Fix objcopy --merge-notes dependency on qsort implementation behavior.
- References: <CAB=4xhpfsDVkBpqsS2AQrb9ow8omU86ozxzv37FeJYxyM9UYDw@mail.gmail.com> <b4fee988-d68b-71a2-a473-0335b277b11f@redhat.com>
- Reply-to: Roland McGrath <mcgrathr at google dot com>
On Mon, Jan 27, 2020 at 4:54 AM Nick Clifton <nickc@redhat.com> wrote:
> It is. Or at least that is what should happen for an optimal merge.
> It is not an error for the notes not to be merged, it is just a case
> that an opportunity for merging was missed.
Ok. That's what I thought. Thanks for the clarification.
> > then some different fix is
> > needed to achieve that and the test suite needs to change its
> > expectations
>
> If you would like to look into this and suggest a patch then please
> do. Otherwise I will add it to my list of things to do.
I'm not going to work on this, sorry.
> Yes for both - please apply.
Done.
Thanks,
Roland