This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: Strange singular/plural messages in 2.33.90
- From: Nick Clifton <nickc at redhat dot com>
- To: Alan Modra <amodra at gmail dot com>
- Cc: binutils at sourceware dot org
- Date: Mon, 27 Jan 2020 12:30:19 +0000
- Subject: Re: Strange singular/plural messages in 2.33.90
- References: <24106.7214.11528.29033@gargle.gargle.HOWL> <bd25f515-232c-3843-ec75-b6e204aa6b6c@redhat.com> <20200127121500.GU4433@bubble.grove.modra.org>
Hi Alan,
> Is there a need to report "debuginfod: "? I'm thinking we could
> consolidate these messages a little to cut down on translation work.
> OK? (-w diff shown to exclude all the leading space to tab changes)
No, but ... there is a possibility for user confusion here.
The warning comes from the debuginfod code attempting to compute
a build id, but the message does not indicate this. Thus a user
seeing the message is not going to understand why readelf is
complaining about a corrupt note, especially if they have not
asked for notes to be displayed. Plus these days most binaries
have multiple note sections, so it is not at all clear which note
is actually corrupt.
I think that we would better off saying something like:
Malformed note at offset %x in section %s encountered
whilst computing build-id.
This also handily removes the need for a plural form of the message.
What do you think ?
Cheers
Nick