This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] Fix problem with COFF and plugins
- From: Andreas Schwab <schwab at suse dot de>
- To: Alan Modra <amodra at gmail dot com>
- Cc: Andrew Jenner <andrew at codesourcery dot com>, binutils at sourceware dot org
- Date: Mon, 27 Jan 2020 12:26:27 +0100
- Subject: Re: [PATCH] Fix problem with COFF and plugins
- References: <0390fe12-85dc-6e03-5d02-7f3d9bad85fc@codesourcery.com> <20190611104131.GA16672@bubble.grove.modra.org>
On Jun 11 2019, Alan Modra wrote:
> I think I prefer to change bfd_check_format_matches. Since I don't
> have a good test environment for mingw, would you please test whether
> the following is good?
>
> * format.c (bfd_check_format_matches): Don't match plugin target
> if another target matches. Expand comment.
> * targets.c (_bfd_target_vector): Move plugin_vec after all other
> non-corefile targets, outside !SELECT_VECS.
> * config.bfd: Don't handle targ=plugin here.
> * configure.ac: Don't add plugin to enable_targets or handle in
> target loop setting selvecs and other target vars.
> * configure: Regenerate.
AFAICT, this causes cpu-plugin.c to be unused.
Andreas.
--
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."