This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
[PATCH] x86-64: Skip GNU2 TLS tests only without compiler support
- From: "H.J. Lu" <hjl dot tools at gmail dot com>
- To: binutils at sourceware dot org
- Date: Wed, 22 Jan 2020 06:25:45 -0800
- Subject: [PATCH] x86-64: Skip GNU2 TLS tests only without compiler support
After fixing:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93319
https://sourceware.org/bugzilla/show_bug.cgi?id=25416
-mtls-dialect=gnu2 is working for x32 with GCC 10. Skip GNU2 TLS tests
only if compiler doesn't support it.
PR ld/25416
* testsuite/ld-x86-64/tls.exp: Skip GNU2 TLS tests only without
compiler support.
---
ld/ChangeLog | 6 ++++++
ld/testsuite/ld-x86-64/tls.exp | 4 ++--
2 files changed, 8 insertions(+), 2 deletions(-)
diff --git a/ld/ChangeLog b/ld/ChangeLog
index b196d2167f..f71c13564d 100644
--- a/ld/ChangeLog
+++ b/ld/ChangeLog
@@ -1,3 +1,9 @@
+2020-01-22 H.J. Lu <hongjiu.lu@intel.com>
+
+ PR ld/25416
+ * testsuite/ld-x86-64/tls.exp: Skip GNU2 TLS tests only without
+ compiler support.
+
2020-01-22 Alan Modra <amodra@gmail.com>
* testsuite/ld-powerpc/tlsdesc3.d,
diff --git a/ld/testsuite/ld-x86-64/tls.exp b/ld/testsuite/ld-x86-64/tls.exp
index 223c81e1af..2ac455ac2f 100644
--- a/ld/testsuite/ld-x86-64/tls.exp
+++ b/ld/testsuite/ld-x86-64/tls.exp
@@ -177,8 +177,8 @@ run_ld_link_exec_tests [list \
] \
]
-# -mtls-dialect=gnu2 isn't supported on x32.
-if [istarget "x86_64-*-linux*-gnux32"] {
+# Skip if -mtls-dialect=gnu2 doesn't work.
+if { ![run_host_cmd_yesno $CC "-c -O2 -fPIC $GNU2_CFLAGS $srcdir/$subdir/tlsdesc1b.c -o tmpdir/tlsdesc1b.o"] } {
return
}
--
2.24.1