Re: Recent change regressing various targets

["H.J. Lu" <hjl dot tools at gmail dot com>]

On Tue, Jan 21, 2020 at 3:34 PM Jeff Law <law@redhat.com> wrote:
>
>
> This change:
>
> > commit b4654b109bd023d0a22f445db7d4e27f769593f4 (HEAD, refs/bisect/bad)
> > Author: H.J. Lu <hjl.tools@gmail.com>
> > Date:   Tue Jan 21 05:43:59 2020 -0800
> >
> >     pr23900-1.d: Also check PT_GNU_PROPERTY program header
> >
> >     Also pass -l to readelf to check PT_GNU_PROPERTY program header.
> >
> >             PR ld/23900
> >             * testsuite/ld-elf/pr23900-1.d: Also pass -l to readelf.
> >
>
> Is causing various targets to fail the pr23900-1 test when previously
> they passed the test:
>
> > Target is sh3eb-unknown-linux-gnu
> > Host   is x86_64-pc-linux-gnu
> >
> >                 === ld tests ===
> >
> > Schedule of variations:
> >     unix
> >
> > Running target unix
> > Using /usr/share/dejagnu/baseboards/unix.exp as board description file for target.
> > Using /usr/share/dejagnu/config/unix.exp as generic interface file for target.
> > Using /home/law/UPSTREAM/binutils-gdb/ld/testsuite/config/default.exp as tool-and-target-specific interface file.
> > WARNING: Assuming target board is the local machine (which is probably wrong).
> > You may need to set your DEJAGNU environment variable.
> > Running /home/law/UPSTREAM/binutils-gdb/ld/testsuite/ld-elf/elf.exp ...
> > FAIL: ld-elf/pr23900-1
> >
>
> sh3eb-linux-gnu is a good example.  There are others.
>

I am checking in this.

Sorry for that.

-- 
H.J.

From 1e1613647fc5da78f7924f8264b09eeed6362987 Mon Sep 17 00:00:00 2001
From: "H.J. Lu" <hjl.tools@gmail.com>
Date: Tue, 21 Jan 2020 16:20:38 -0800
Subject: [PATCH] pr23900-1.d: Adjusted

Linux program headers may look like

Section to Segment mapping:
  Segment Sections...
   00     .note.gnu.property .text
   01     .note.gnu.property
   02     .note.gnu.property

or

Section to Segment mapping:
  Segment Sections...
   00     .note.gnu.property
   01     .text
   02     .note.gnu.property
   03     .note.gnu.property

Update pr23900-1.d to accept both.

	* testsuite/ld-elf/pr23900-1.d: Adjusted.
---
 ld/ChangeLog                    | 4 ++++
 ld/testsuite/ld-elf/pr23900-1.d | 2 +-
 2 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/ld/ChangeLog b/ld/ChangeLog
index a686c187cb..369ffee04a 100644
--- a/ld/ChangeLog
+++ b/ld/ChangeLog
@@ -1,3 +1,7 @@
+2020-01-21  H.J. Lu  <hongjiu.lu@intel.com>
+
+	* testsuite/ld-elf/pr23900-1.d: Adjusted.
+
 2020-01-21  H.J. Lu  <hongjiu.lu@intel.com>
 
 	* testsuite/ld-elf/pr23900-1.d: Also pass -l to readelf.
diff --git a/ld/testsuite/ld-elf/pr23900-1.d b/ld/testsuite/ld-elf/pr23900-1.d
index 8f8c7ccf03..da0fcbb4e3 100644
--- a/ld/testsuite/ld-elf/pr23900-1.d
+++ b/ld/testsuite/ld-elf/pr23900-1.d
@@ -5,7 +5,7 @@
 #...
   GNU_PROPERTY .*
 #...
- +[0-9]+ +\.note\.gnu\.property 
+ +[0-9]+ +.*\.note\.gnu\.property.*
 #...
  +[0-9]+ +\.note\.gnu\.property 
 #...
-- 
2.24.1