This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: V3 [PATCH 4/4] i386: Add tests for -malign-branch-boundary and -malign-branch
- From: "H.J. Lu" <hjl dot tools at gmail dot com>
- To: Jan Beulich <jbeulich at suse dot com>
- Cc: Hongtao Liu <crazylht at gmail dot com>, Lili Cui <lili dot cui at intel dot com>, Alan Modra <amodra at gmail dot com>, Binutils <binutils at sourceware dot org>
- Date: Tue, 14 Jan 2020 09:17:30 -0800
- Subject: Re: V3 [PATCH 4/4] i386: Add tests for -malign-branch-boundary and -malign-branch
- References: <20191206191100.25079-1-hjl.tools@gmail.com> <20191206191100.25079-5-hjl.tools@gmail.com> <20191216023414.GC32672@bubble.grove.modra.org> <CAMZc-bw=eTpCzFTAzFGgbzS7TbGRC6v-51_Nh=K87faezqmz=A@mail.gmail.com> <CAMZc-bxw3QL6XA8T6UVvFp5zu+QiXa70KMdN2xiuWVo-Ed-T3A@mail.gmail.com> <CAMe9rOpFxFKUweq7aAfb0oSdc+pe3OLuiZ=udNJn7cA42AG-Rg@mail.gmail.com> <12984481-50eb-712a-2271-a73b37c76cd9@suse.com>
On Tue, Jan 14, 2020 at 9:08 AM Jan Beulich <jbeulich@suse.com> wrote:
>
> On 14.01.2020 18:02, H.J. Lu wrote:
> > --- a/ld/testsuite/ld-i386/align-branch-1.d
> > +++ b/ld/testsuite/ld-i386/align-branch-1.d
> > @@ -10,16 +10,16 @@ Disassembly of section .text:
> >
> > [a-f0-9]+ <_start>:
> > +[a-f0-9]+: 85 d2 test %edx,%edx
> > - +[a-f0-9]+: 74 20 je 8049024 <_start\+0x24>
> > + +[a-f0-9]+: 74 20 je +[a-f0-9]+ <_start\+0x24>
> > +[a-f0-9]+: 85 d2 test %edx,%edx
> > - +[a-f0-9]+: 74 1c je 8049024 <_start\+0x24>
> > + +[a-f0-9]+: 74 1c je +[a-f0-9]+ <_start\+0x24>
> > +[a-f0-9]+: 85 ff test %edi,%edi
> > - +[a-f0-9]+: 74 18 je 8049024 <_start\+0x24>
> > + +[a-f0-9]+: 74 18 je +[a-f0-9]+ <_start\+0x24>
> > +[a-f0-9]+: 65 a1 00 00 00 00 mov %gs:0x0,%eax
> > +[a-f0-9]+: 90 nop
> > +[a-f0-9]+: 8d 74 26 00 lea 0x0\(%esi,%eiz,1\),%esi
> > +[a-f0-9]+: 3e 3e 3e 8b 90 fc ff ff ff ds ds mov %ds:-0x4\(%eax\),%edx
> > +[a-f0-9]+: 85 d2 test %edx,%edx
> > - +[a-f0-9]+: 74 00 je 8049024 <_start\+0x24>
> > + +[a-f0-9]+: 74 00 je +[a-f0-9]+ <_start\+0x24>
>
> Are the + characters before the [ ones really needed here?
> They look certainly oddly placed.
>
Feel free to remove it.
Thanks.
--
H.J.