Re: [PATCH v3 03/10] x86: move certain MOVSX/MOVZX tests

["H.J. Lu" <hjl dot tools at gmail dot com>]

On Fri, Dec 27, 2019 at 1:24 AM Jan Beulich <JBeulich@suse.com> wrote:
>
> Some encodings are about to gain a warning - move them from test cases
> not expecting any diagnostics to the new, dedicated ones, to allow
> better focus on the actual changes in the subsequent patch.
>
> The new tests added have some wrong expectations right now, which will
> be corrected by the next patch. The test is being added here to make
> more visible which cases actually were wrong (and hence get changed),
> besides demonstrating that in the vast majority of cases the subsequent
> change doesn't alter generated code.

We can't change the encoding nor disallow it.  At most, we can issue a
warning.   If it is the case, calling it "wrong" isn't accurate.

> gas/
> 2020-01-XX  Jan Beulich  <jbeulich@suse.com>
>
>         * testsuite/gas/i386/i386.s, testsuite/gas/i386/iamcu-1.s,
>         testsuite/gas/i386/ilp32/x86-64.s: Move ambiguous operand size
>         tests ...
>         * testsuite/gas/i386/noreg16.s, testsuite/gas/i386/noreg32.s,
>         testsuite/gas/i386/noreg64.s: ... here.
>         * testsuite/gas/i386/x86_64.s: Likewise. Add further MOVSXD
>         cases.
>         * testsuite/gas/i386/i386.d, testsuite/gas/i386/i386-intel.d
>         testsuite/gas/i386/iamcu-1.d, testsuite/gas/i386/ilp32/x86-64.d,
>         testsuite/gas/i386/k1om.d, testsuite/gas/i386/l1om.d,
>         testsuite/gas/i386/noreg16.d, testsuite/gas/i386/noreg32.d,
>         testsuite/gas/i386/noreg64.d, testsuite/gas/i386/x86_64-intel.d,
>         testsuite/gas/i386/x86_64.d: Adjust expectations.
>         * testsuite/gas/i386/movx16.s, testsuite/gas/i386/movx16.l,
>         testsuite/gas/i386/movx32.s, testsuite/gas/i386/movx32.l,
>         testsuite/gas/i386/movx64.s, testsuite/gas/i386/movx64.l: New.
>         * testsuite/gas/i386/i386.exp: Run new tests.



-- 
H.J.