This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: RFC: Adding visualization of jumps to objdump's disassembly output
- From: Nick Clifton <nickc at redhat dot com>
- To: Tom Tromey <tom at tromey dot com>
- Cc: binutils at sourceware dot org, tstroege at gmx dot de
- Date: Thu, 9 Jan 2020 12:02:47 +0000
- Subject: Re: RFC: Adding visualization of jumps to objdump's disassembly output
- References: <87o8vfruyf.fsf@redhat.com> <87h815zqs2.fsf@tromey.com>
Hi Tom,
> Is there any way to put this into libopcodes or BFD, rather than binutils?
> I think it would make a nice addition to gdb's "disassemble" command.
Hmm, not sure. At the moment the code is baked into objdump's disassembly
functions. I think that in order to move it into a library we would have
to move all of the disassembly code there, not just the visualization code.
I will look into doing this as a future enhancement. But for now I just
want to get the feature in before the 2.34 branch happens.
> Nick> +/* This code was taken from:
> Nick> + https://en.wikipedia.org/wiki/Jenkins_hash_function
> Nick> + TODO: Does this work with the GPL? */
>
> I think this should be resolved before checking it in. If it's just a
> generic hash function you need, there's one in hashtab.c though.
Yes, I have had a look into this and Jenkins function will be OK.
Plus according to Thomas it produces a better color selection than
the default hash function. So I will be updating the patch to use
the Jenkins one.
Cheers
Nick