This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH v2] RISC-V: Change -march parsing.
- From: Kito Cheng <kito dot cheng at gmail dot com>
- To: Palmer Dabbelt <palmerdabbelt at google dot com>
- Cc: Maxim Blinov <maxim dot blinov at embecosm dot com>, Jim Wilson <jimw at sifive dot com>, Binutils <binutils at sourceware dot org>
- Date: Thu, 9 Jan 2020 14:20:36 +0800
- Subject: Re: [PATCH v2] RISC-V: Change -march parsing.
- References: <20191204113353.29853-1-maxim.blinov@embecosm.com> <CA+yXCZAz6gZkFwCTREyfyHZLbKcScPMAnEz-Dqh_aWs46XrOKg@mail.gmail.com> <20191209171047.GA24814@fujitsu> <mhng-b54ce60b-7d02-400c-a0af-33258dcf7fe9@palmerdabbelt-glaptop> <CA+yXCZDVNYb6U9yoZUW4DjANkfRmwkHW3UmfUdOj_eka1-9bpA@mail.gmail.com>
Hi Palmer:
Ping, do you mind accept this patch and then we'll send follow up
patch for Zifence and Zicsr?
On Mon, Dec 23, 2019 at 3:21 PM Kito Cheng <kito.cheng@gmail.com> wrote:
>
> Hi Maxim:
>
> LGTM, just need Palmer or Jim to approve :)
>
> Hi Palmer:
>
> >> +static bfd_boolean
> >> +riscv_ext_x_valid_p (const char *arg)
> >> +{
> >> + if (!strcasecmp (arg, "x"))
> >> + return FALSE;
> >> +
> >> + return TRUE;
> >
> > This allows any X extension through but then goes ahead to not provide any
> > support for those extensions. I can understand providing some scaffolding to
> > users to turn on their custom extensions, but we should fail quickly on any
> > extensions that aren't supported.
>
> We bypass any X extension now, and one concern is we can't testing any
> X parsing/combine logic if we reject that.